This repository was archived by the owner on May 9, 2024. It is now read-only.
Initial windows CI that should build release from sources #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gshimansky
force-pushed
the
gregory/windows-ci-build
branch
5 times, most recently
from
4b8c7ac to
d6b6aa6
Compare
gshimansky
force-pushed
the
gregory/windows-ci-build
branch
from
b79b19e to
3e32aa6
Compare
|
@gshimansky can you rebase this on main since #431 was merged? |
Signed-off-by: Gregory Shimansky <[email protected]>
gshimansky
force-pushed
the
gregory/windows-ci-build
branch
from
3e32aa6 to
4d9c6fb
Compare
Ok, rebased. |
| uses: ./.github/workflows/windows-build.yml | ||
| with: | ||
| name: release | ||
| options: -DCMAKE_BUILD_TYPE=Release -DENABLE_FOLLY=off -G "Visual Studio 17 2022" |
There was a problem hiding this comment.
Does folly not work on windows?
There was a problem hiding this comment.
I suppose it works but there is no conda-forge build on windows
https://github.com/conda-forge/folly-feedstock/blob/main/recipe/meta.yaml#L19
There was a problem hiding this comment.
We decided to skip it for now, which would use std lib atomics on Windows. The Arena allocator is a bigger issue we need to solve.
There was a problem hiding this comment.
Someone is trying to write windows build so maybe eventually they will add one
conda-forge/folly-feedstock#98
alexbaden
approved these changes
Apr 29, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Subj