Skip to content
This repository was archived by the owner on May 9, 2024. It is now read-only.

Added dependency on Logger and OSDependent libraries #239

Merged
merged 1 commit into from
Mar 8, 2023
Merged

Added dependency on Logger and OSDependent libraries #239

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion omniscidb/CudaMgr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,4 +4,4 @@ else()
add_library(CudaMgr CudaMgrNoCuda.cpp)
endif()

target_link_libraries(CudaMgr ${CUDA_LIBRARIES})
target_link_libraries(CudaMgr Logger ${CUDA_LIBRARIES})
2 changes: 1 addition & 1 deletion omniscidb/L0Mgr/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ else()
endif()

add_library(L0Mgr ${L0_SOURCES})
target_link_libraries(L0Mgr ${LevelZero_LIBRARIES})
target_link_libraries(L0Mgr Logger ${LevelZero_LIBRARIES})

3 changes: 3 additions & 0 deletions omniscidb/OSDependent/Windows/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,4 @@
add_library(OSDependent ${OSDEPENDENT_SOURCE_FILES})
set_target_properties(OSDependent PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/..)

target_link_libraries(OSDependent Logger)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, Logger should be a private dependency here as well as in the device managers. What made you decide otherwise?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't made any decisions and simply copied these lines from Unix/CMakeLists.txt.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't hurt too much, we'll deal with it separately.

2 changes: 1 addition & 1 deletion omniscidb/SqliteConnector/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
add_library(SqliteConnector SqliteConnector.cpp SqliteConnector.h)

target_link_libraries(SqliteConnector PUBLIC sqlite3 PRIVATE ${Boost_THREAD_LIBRARY})
target_link_libraries(SqliteConnector PUBLIC sqlite3 PRIVATE Logger ${Boost_THREAD_LIBRARY})
2 changes: 1 addition & 1 deletion omniscidb/UdfCompiler/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ find_package(Clang REQUIRED)
include_directories(${CLANG_INCLUDE_DIRS})
add_definitions(${CLANG_DEFINITIONS})

target_link_libraries(UdfCompiler Logger ${clang_libs})
target_link_libraries(UdfCompiler OSDependent ${clang_libs})