This repository was archived by the owner on May 9, 2024. It is now read-only.
Added dependency on Logger and OSDependent libraries #239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gregory Shimansky <[email protected]>
| @@ -1 +1,4 @@ | |||
| add_library(OSDependent ${OSDEPENDENT_SOURCE_FILES}) | |||
| set_target_properties(OSDependent PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/..) | |||
|
|
|||
| target_link_libraries(OSDependent Logger) | |||
There was a problem hiding this comment.
IMO, Logger should be a private dependency here as well as in the device managers. What made you decide otherwise?
There was a problem hiding this comment.
I haven't made any decisions and simply copied these lines from Unix/CMakeLists.txt.
There was a problem hiding this comment.
I guess it doesn't hurt too much, we'll deal with it separately.
kurapov-peter
approved these changes
Mar 8, 2023
| @@ -1 +1,4 @@ | |||
| add_library(OSDependent ${OSDEPENDENT_SOURCE_FILES}) | |||
| set_target_properties(OSDependent PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${CMAKE_CURRENT_BINARY_DIR}/..) | |||
|
|
|||
| target_link_libraries(OSDependent Logger) | |||
There was a problem hiding this comment.
I guess it doesn't hurt too much, we'll deal with it separately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added explicit dependencies from Logger and OSDependent libraries. They are required on windows because unresolved symbols are not allowed.