INSTUI-4080 fix(ui-selectable): fix Select options not being selectable on iOS Safari with VoiceOver on #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fari with VoiceOver on aria-owns seems to be misused here
matyasf
changed the title
|
|
I've verified that this fix does not fix the issue on Android (but it does on iOS) |
ToMESSKa
approved these changes
Sep 11, 2024
HerrTopi
approved these changes
Sep 12, 2024
matyasf
added a commit
that referenced
this pull request
Sep 18, 2024
…fari with VoiceOver on aria-owns seems to be misused here. It rearranges the DOM seen by the screenreader, so the subtree owned by the element will be its child. In our case it meant that a popup will the the child of an input component. Backport of #1668 TEST PLAN: Test all examples of Select, SimpleSelect, Selectable with keyboard navigation and VoiceOver. Test on mobile devices with TalkBack/VoiceOver and Windows too if possible
HerrTopi
pushed a commit
that referenced
this pull request
Sep 18, 2024
…fari with VoiceOver on aria-owns seems to be misused here. It rearranges the DOM seen by the screenreader, so the subtree owned by the element will be its child. In our case it meant that a popup will the the child of an input component. Backport of #1668 TEST PLAN: Test all examples of Select, SimpleSelect, Selectable with keyboard navigation and VoiceOver. Test on mobile devices with TalkBack/VoiceOver and Windows too if possible
matyasf
added a commit
that referenced
this pull request
Sep 19, 2024
…fari with VoiceOver on aria-owns seems to be misused here. It rearranges the DOM seen by the screenreader, so the subtree owned by the element will be its child. Backport of #1668 TEST PLAN: Test all examples of Select, SimpleSelect, Selectable with keyboard navigation and VoiceOver. Test on mobile devices with TalkBack/VoiceOver and Windows too if possible
matyasf
added a commit
that referenced
this pull request
Sep 23, 2024
…fari with VoiceOver on aria-owns seems to be misused here. It rearranges the DOM seen by the screenreader, so the subtree owned by the element will be its child. Backport of #1668 TEST PLAN: Test all examples of Select, SimpleSelect, Selectable with keyboard navigation and VoiceOver. Test on mobile devices with TalkBack/VoiceOver and Windows too if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
aria-ownsseems to be misused here. It rearranges the DOM seen by the screenreader, so the subtree owned by the element will be its child. In our case it meant that a popup will the the child of aninputcomponent.Also its very rarely used, see https://www.makethingsaccessible.com/guides/aria-controls-vs-aria-owns/ , there is just one sample use case for it at W3C (a navigation treeview)
To test:
Note: This will need to be ported to InstUI v8 and v9