fix(ui-selectable): fix Select options not being selectable on iOS Sa…

…fari with VoiceOver on aria-owns seems to be misused here
instructure · Sep 12, 2024 · aae996f · aae996f
1 parent 07840fb
commit aae996f
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 3 deletions.
diff --git a/packages/ui-selectable/src/Selectable/__tests__/Selectable.test.tsx b/packages/ui-selectable/src/Selectable/__tests__/Selectable.test.tsx
@@ -800,14 +800,12 @@ describe('<Selectable />', async () => {
 
       expect(input.getAttribute('aria-expanded')).to.equal('false')
       expect(input.getAttribute('aria-controls')).to.not.exist()
-      expect(input.getAttribute('aria-owns')).to.not.exist()
 
       await subject.setProps({ isShowingOptions: true })
       expect(input.getAttribute('aria-expanded')).to.equal('true')
       expect(input.getAttribute('aria-controls')).to.equal(
         list.getAttribute('id')
       )
-      expect(input.getAttribute('aria-owns')).to.equal(list.getAttribute('id'))
     })
 
     it('should set appropriate props based on highlightedOptionId', async () => {

diff --git a/packages/ui-selectable/src/Selectable/index.tsx b/packages/ui-selectable/src/Selectable/index.tsx
@@ -200,7 +200,6 @@ class Selectable extends Component<SelectableProps> {
             )!,
             'aria-haspopup': 'listbox',
             'aria-expanded': isShowingOptions,
-            'aria-owns': isShowingOptions ? this._listId : undefined,
             'aria-controls': isShowingOptions ? this._listId : undefined,
             'aria-describedby': this._descriptionId,
             'aria-activedescendant': isShowingOptions