feat(autoprofile): rework prebuilds #990
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
force-pushed
the
feat/autoprofiler-prebuild
branch
2 times, most recently
from
ac9c34a to
51da462
Compare
|
RFR but do not merge. We need to wait for the merge & release of prebuild/prebuildify-cross#18. |
|
Awesome work 🥳 |
kirrg001
commented
Jan 18, 2024
aryamohanan
reviewed
Jan 19, 2024
| const childProcess = require('child_process'); | ||
|
|
||
| const minNodeVersion = require('../package.json').engines.node; | ||
| const excludeTargets = ['15.0.0', '17.0.0', '19.0.0']; |
There was a problem hiding this comment.
Suggestion:We are keeping a static array for excludeTargets. This array is used only if no ABI is specified. Consider adding a comment here or mentioning this information in the contributing.md file for clarity and future contributors.
There was a problem hiding this comment.
Yeah hmmm I am wondering if we should remove the whole logic if no abi version is present.
It was helpful for the initial build, but in the future we will only build a specific abi version.
aryamohanan
reviewed
Jan 22, 2024
|
prebuildify-cross released 5.1.0. Will update 👍 |
kirrg001
force-pushed
the
feat/autoprofiler-prebuild
branch
from
3bb4a96 to
338cf41
Compare
kirrg001
changed the title
kirrg001
changed the title
4 tasks
refs 149946
[ci skip]
[ci skip]
[ci skip]
kirrg001
force-pushed
the
feat/autoprofiler-prebuild
branch
from
d61c800 to
6f0093c
Compare
|
Closing because of wrong branch name. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs 149946
Move away from manual prebuilds for the autoprofile package to using prebuildify.
The PR replaces the prebuilds for darwin x64 and linux x64 (musl + glibc) and adds more prebuilds for darwin arm64 (m1), linux arm64 and armv6 and armv7 (raspberry pi).
This is the first iteration. The next iteration is to get rid of the manual prebuilds in the shared metrics package.
Testing / QA
Installing the autoprofiler on darwin x64 from local source without prebuild
Installing the autoprofiler on darwin x64 from local source with prebuild
Installing the autoprofiler on darwin x64 from npm including manual prebuilds
-> caused by a bug in the node-gyp-fallback script.
Installing the autoprofiler on linux x64 musl from npm including manual prebuilds
Installing the autoprofiler on linux x64 musl from local source with prebuild
Installing the autoprofiler on linux x64 musl from local source without prebuild
Installing the autoprofiler on linux x64 glibc from npm including manual prebuilds
Installing the autoprofiler on linux x64 glibc from local source with prebuild
Installing the autoprofiler on linux x64 glibc from local source without prebuild
Installing the autoprofiler on linux arm64 glibc from npm including manual prebuilds
Installing the autoprofiler on linux arm64 glibc from local source with prebuild
Tasks