Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: added support for Node v22 #1132

Merged
merged 6 commits into from
Apr 30, 2024
Merged

feat: added support for Node v22 #1132

merged 6 commits into from
Apr 30, 2024

Conversation

kirrg001
Copy link
Contributor

@kirrg001 kirrg001 commented Apr 26, 2024 •
edited
Loading

refs INSTA-2790

https://nodejs.org/en/blog/announcements/v22-release-announce

No breaking changes. Interesting changes for us:

The browser-compatible implementation of WebSocket, previously behind the flag --experimental-websocket, will be enabled by default. This provides a WebSocket client to Node.js without external dependencies.
This release adds require() support for synchronous ESM graphs under the flag --experimental-require-module.
If --experimental-require-module is enabled, and the ECMAScript module being loaded by require() meets the following requirements:

https://hub.docker.com/_/node

@kirrg001 kirrg001 force-pushed the node-22 branch 3 times, most recently from 2717fcd to 02098c3 Compare April 30, 2024 07:11
@kirrg001 kirrg001 marked this pull request as ready for review April 30, 2024 08:28
@kirrg001 kirrg001 requested a review from a team as a code owner April 30, 2024 08:28
aryamohanan
aryamohanan approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@aryamohanan aryamohanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kirrg001 kirrg001 merged commit 6d08f43 into main Apr 30, 2024
1 check passed
@kirrg001 kirrg001 deleted the node-22 branch April 30, 2024 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aryamohanan aryamohanan aryamohanan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kirrg001 @aryamohanan