Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: updated comments to reflect targeting of the next major release #1379

Merged
merged 2 commits into from
Oct 11, 2024
Merged

chore: updated comments to reflect targeting of the next major release #1379

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc96678
chore: comments updated for v4
aryamohanan Oct 11, 2024
1dc9607
chore: updated the comments
aryamohanan Oct 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/tracing/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,7 +181,7 @@ exports.init = function init(_config, downstreamConnection, _processIdentityProv
console.debug(`The App is using the following preload flags: ${preloadFlags}`);
}

// Consider removing this in the next major release(v4.x) of the @instana package.
// Consider removing this in the next major release of the @instana package.
if (hasExperimentalLoaderFlag()) {
// eslint-disable-next-line no-console
console.warn(
Expand Down
11 changes: 5 additions & 6 deletions packages/core/src/tracing/instrumentation/cloud/aws-sdk/v3/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,12 +84,11 @@ function shimSmithySend(originalSend) {
if (awsProduct && awsProduct.supportsOperation(command.constructor.name)) {
return awsProduct.instrumentedSmithySend(self, isActive, originalSend, smithySendArgs);
} else {
// This code can be removed once all AWS SDK v3 instrumentations have been refactored to use the new approach
// introduced in https://github.com/instana/nodejs/pull/838 for kinesis. That is: Do not use an explicit
// operationsInfo/operationsMap map that restricts the traced operations to a subset of possible operations, but
// instead allow _all_ operations to be traced, using the operation name from `command.constructor.name` for
// span.data.$spanName.op. We plan to finish this refactoring before or with the next major release (4.x) of the
// @instana packages.
// This logic should not be used in AWS SDK v4. All AWS SDK v4 instrumentations must use the new approach
// introduced in https://github.com/instana/nodejs/pull/838 for Kinesis. That is: Do not use an explicit
// operationsInfo/operationsMap that restricts the traced operations to a subset of possible operations.
// Instead, allow all operations to be traced using the operation name from `command.constructor.name`
// for span.data.$spanName.op.
awsProduct = operationMap[smithySendArgs[0].constructor.name];
if (awsProduct) {
return awsProduct.instrumentedSmithySend(self, isActive, originalSend, smithySendArgs);
Expand Down
2 changes: 1 addition & 1 deletion packages/core/src/util/hook.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const isESMApp = require('./esm').isESMApp;
* Offers support for all native ECMAScript Modules within ESM applications.
* However, it does not provide support for modules loaded from CJS applications.
*
* Note: In the next major release (4.x), we plan to transition all CJS modules in ESM applications to be
* Note: In the next major release, we might transition all CJS modules in ESM applications to be
* supported with iitmHook. For now, this approach is chosen to minimize risk.
*/

Expand Down