chore: updated comments to reflect targeting of the next major release #1379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kirrg001
reviewed
Oct 11, 2024
packages/core/src/util/hook.js
Outdated
| @@ -19,7 +19,7 @@ const isESMApp = require('./esm').isESMApp; | |||
| * Offers support for all native ECMAScript Modules within ESM applications. | |||
| * However, it does not provide support for modules loaded from CJS applications. | |||
| * | |||
| * Note: In the next major release (4.x), we plan to transition all CJS modules in ESM applications to be | |||
| * Note: In the next major release (5.x), we plan to transition all CJS modules in ESM applications to be | |||
There was a problem hiding this comment.
Suggested change
| * Note: In the next major release (5.x), we plan to transition all CJS modules in ESM applications to be | |
| * Note: In the next major release, we might transition all CJS modules in ESM applications to be |
kirrg001
reviewed
Oct 11, 2024
packages/core/src/tracing/index.js
Outdated
| @@ -181,7 +181,7 @@ exports.init = function init(_config, downstreamConnection, _processIdentityProv | |||
| console.debug(`The App is using the following preload flags: ${preloadFlags}`); | |||
| } | |||
|
|
|||
| // Consider removing this in the next major release(v4.x) of the @instana package. | |||
| // Consider removing this in the next major release(v5.x) of the @instana package. | |||
There was a problem hiding this comment.
Suggested change
| // Consider removing this in the next major release(v5.x) of the @instana package. | |
| // Consider removing this in the next major release of the @instana package. |
kirrg001
approved these changes
Oct 11, 2024
aryamohanan
changed the title
kirrg001
approved these changes
Oct 11, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 14, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 18, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 21, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 22, 2024
aryamohanan
added a commit
that referenced
this pull request
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated some comments in the repository to reflect that the updates are targeting next major release instead of v4.