refactor: listing of invalid or missing immutable files in verify command

[turmelclem]

Content

This PR include :

• the move of following algorithms from message.rs back to proving.rs in a new API function called verify_cardano_database :

  • check if immutable files is missing
  • check of tampered files
  • produce a verified merkle proof

• restoring compute_cardano_database_message from message.rs as before pull request List invalid or tampered immutable files in verify command #2637 to only build a Message from a certificate and a merkle proof

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)
  • Add ADR blog post or Dev ADR entry (if relevant)
  • No new TODOs introduced

Issue(s)

Closes #2618

[github-actions]

Test Results

    4 files  ±0    164 suites  ±0   23m 58s ⏱️ +10s
2 181 tests ±0  2 181 ✅ ±0  0 💤 ±0  0 ❌ ±0 
6 706 runs  ±0  6 706 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit fa40323. ± Comparison against base commit 9d9e963.

This pull request removes 13 and adds 13 tests. Note that renamed tests count towards both.

mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_fail_if_immutable_is_missing_and_allow_missing_not_set
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_fail_if_immutable_is_tampered
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_fail_if_immutables_are_missing_and_tampered
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_fail_if_there_is_more_local_immutable_than_verified_digest
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_success_if_immutable_is_missing_and_allow_missing_is_set
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_succeeds
mithril-client ‑ message::tests::compute_cardano_database_message_error::display_immutable_files_should_display_missing_files_only
mithril-client ‑ message::tests::compute_cardano_database_message_error::display_immutable_files_should_display_non_verifiable_files_only
mithril-client ‑ message::tests::compute_cardano_database_message_error::display_immutable_files_should_display_tampered_files_only
mithril-client ‑ message::tests::compute_cardano_database_message_error::display_immutable_files_verification_error_should_displayed_lists_with_10_elements
…

mithril-client ‑ cardano_database_client::proving::tests::cardano_database_verification_error::display_immutable_files_should_display_missing_files_only
mithril-client ‑ cardano_database_client::proving::tests::cardano_database_verification_error::display_immutable_files_should_display_non_verifiable_files_only
mithril-client ‑ cardano_database_client::proving::tests::cardano_database_verification_error::display_immutable_files_should_display_tampered_files_only
mithril-client ‑ cardano_database_client::proving::tests::cardano_database_verification_error::display_immutable_files_verification_error_should_displayed_lists_with_10_elements
mithril-client ‑ cardano_database_client::proving::tests::list_missing_immutable_files::should_return_empty_list_if_missing_files_outside_range
mithril-client ‑ cardano_database_client::proving::tests::list_missing_immutable_files::should_return_empty_list_if_no_missing_files
mithril-client ‑ cardano_database_client::proving::tests::list_missing_immutable_files::should_return_list_of_missing_files_inside_range
mithril-client ‑ cardano_database_client::proving::tests::verify_cardano_database::should_fail_if_immutable_is_missing_and_allow_missing_not_set
mithril-client ‑ cardano_database_client::proving::tests::verify_cardano_database::should_fail_if_immutable_is_tampered
mithril-client ‑ cardano_database_client::proving::tests::verify_cardano_database::should_fail_if_immutables_are_missing_and_tampered
…

♻️ This comment has been updated with latest results.

[jpraynaud]

LGTM 👍