List invalid or tampered immutable files in verify command

[turmelclem]

Content

improve client library and CLI for verify command to list missing, tampered and/or non verifiable files

• verify command can now be use with a range
• a flag can be use (--allow-missing) to not throw error if immutable file is missing

Pre-submit checklist

• Branch
  • Tests are provided (if possible)
  • Crates versions are updated (if relevant)
  • CHANGELOG file is updated (if relevant)
  • Commit sequence broadly makes sense
  • Key commits have useful messages
• PR
  • All check jobs of the CI have succeeded
  • Self-reviewed the diff
  • Useful pull request description
  • Reviewer requested
• Documentation
  • Update README file (if relevant)
  • Update documentation website (if relevant)
  • Add dev blog post (if relevant)
  • Add ADR blog post or Dev ADR entry (if relevant)
  • No new TODOs introduced

Comments

Issue(s)

Closes #2618

[github-actions]

Test Results

    4 files  ± 0    164 suites  ±0   22m 31s ⏱️ -54s
2 181 tests +16  2 181 ✅ +16  0 💤 ±0  0 ❌ ±0 
6 706 runs  +64  6 706 ✅ +64  0 💤 ±0  0 ❌ ±0 

Results for commit 9370314. ± Comparison against base commit 0461172.

This pull request removes 1 and adds 17 tests. Note that renamed tests count towards both.

mithril-client ‑ cardano_database_client::proving::tests::compute_merkle_proof::compute_merkle_proof_succeeds

mithril-client ‑ cardano_database_client::proving::tests::download_and_verify_digests::download_and_verify_digest_should_return_digest_map_acording_to_beacon
mithril-client ‑ cardano_database_client::proving::tests::list_immutable_files_not_verified::should_return_empty_list_when_no_tampered_files
mithril-client ‑ cardano_database_client::proving::tests::list_immutable_files_not_verified::should_return_list_with_non_verifiable
mithril-client ‑ cardano_database_client::proving::tests::list_immutable_files_not_verified::should_return_list_with_tampered_files
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_fail_if_immutable_is_missing_and_allow_missing_not_set
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_fail_if_immutable_is_tampered
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_fail_if_immutables_are_missing_and_tampered
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_fail_if_there_is_more_local_immutable_than_verified_digest
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_should_success_if_immutable_is_missing_and_allow_missing_is_set
mithril-client ‑ message::tests::cardano_database_message::compute_cardano_database_message_succeeds
…

♻️ This comment has been updated with latest results.

[Copilot]

Pull Request Overview

This PR enhances the Cardano database snapshot verification by listing missing or tampered immutable files instead of failing silently. It refactors the digest download and Merkle-proof verification into a unified flow, introduces detailed error types with file listings, and updates the CLI to surface these details in both JSON and human-readable formats.

• Refactored compute_merkle_proof into download_and_verify_digests, returning VerifiedDigests (digest map + Merkle tree).
• Extended MessageBuilder::compute_cardano_database_message to accept VerifiedDigests, handle an allow_missing flag, and return rich error information (ImmutableFilesLists).
• Updated CLI commands to write JSON error files and print counts of missing/tampered files.

Reviewed Changes

Copilot reviewed 10 out of 10 changed files in this pull request and generated 5 comments.

Show a summary per file

File	Description
mithril-client/tests/cardano_db_snapshot_list_get_download_verify.rs	Updated tests to use download_and_verify_digests and VerifiedDigests.
mithril-client/src/message.rs	Added ImmutableFilesLists, ComputeCardanoDatabaseMessageError, and enhanced compute_cardano_database_message.
mithril-client/src/cardano_database_client/proving.rs	Replaced compute_merkle_proof with download_and_verify_digests returning VerifiedDigests.
mithril-client/src/cardano_database_client/api.rs	Updated public API to expose download_and_verify_digests.
mithril-client-cli/src/commands/cardano_db/verify.rs	Integrated new error handling in the verify command and JSON output.

[jpraynaud]

LGTM 👍