Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DDW-462] Use "taskkill" to kill processes with pid on Windows #1162

Conversation

DominikGuzei
Copy link
Member

This PR tries to solve an issue on Windows where an existing cardano-node sometimes cannot be killed by using normal process.kill(pid) because of a known issue in node.js.


Review Checklist:

Basics

  • PR is updated to the most recent version of target branch (and there are no conflicts)
  • PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub
  • Automated tests: All acceptance tests are passing (yarn run test)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in development build (yarn run dev)
  • Manual tests (minimum tests should cover newly added feature/fix): App works correctly in production build (yarn run package / CI builds)
  • There are no flow errors or warnings (yarn run flow:test)
  • There are no lint errors or warnings (yarn run lint)
  • Text changes are proofread and approved (Jane Wild)
  • There are no missing translations (running yarn run manage:translations produces no changes)
  • UI changes look good in all themes (Alexander Rukin)
  • Storybook works and no stories are broken (yarn run storybook)
  • In case of dependency changes yarn.lock file is updated

Code Quality

  • Important parts of the code are properly documented and commented
  • Code is properly typed with flow
  • React components are split-up enough to avoid unnecessary re-rendering
  • Any code that only works in Electron is neatly separated from components

Testing

  • New feature / change is covered by acceptance tests
  • All existing acceptance tests are still up-to-date
  • New feature / change is covered by Daedalus Testing scenario
  • All existing Daedalus Testing scenarios are still up-to-date

After Review:

  • Merge PR
  • Delete source branch
  • Move ticket to done on the Youtrack board

@nikolaglumac nikolaglumac changed the title [DDW-462] use taskkill to kill processes with pid on windows [DDW-462] Use taskkill to kill processes with pid on Windows Nov 7, 2018
@nikolaglumac nikolaglumac changed the title [DDW-462] Use taskkill to kill processes with pid on Windows [DDW-462] Use "taskkill" to kill processes with pid on Windows Nov 7, 2018
@DominikGuzei
Copy link
Member Author

@nikolaglumac i can confirm that this is working on OSX - i tested it against latest develop which supports injected faults (and thus enables us to test these edge cases)! 🎉

Should i create a separate PR against develop or will we merge the release branch back?

@nikolaglumac
Copy link
Contributor

🎉 🎉 🎉 🎉 🎉 🎉 🎉
AWESOMEEEE
🎉 🎉 🎉 🎉 🎉 🎉 🎉

No need to create another PR - we will merge release branch into develop tomorrow :)

Copy link
Contributor

@nikolaglumac nikolaglumac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Amazing fix @DominikGuzei ! 👍

@nikolaglumac nikolaglumac merged commit 5a0722d into release/0.12.0 Nov 8, 2018
@nikolaglumac nikolaglumac deleted the fix/ddw-462-node-restarting-not-working-on-windows branch November 8, 2018 09:01
@nikolaglumac nikolaglumac mentioned this pull request Nov 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants