-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DDW-462] Use "taskkill" to kill processes with pid on Windows #1162
[DDW-462] Use "taskkill" to kill processes with pid on Windows #1162
Conversation
@nikolaglumac i can confirm that this is working on OSX - i tested it against latest Should i create a separate PR against |
🎉 🎉 🎉 🎉 🎉 🎉 🎉 No need to create another PR - we will merge release branch into develop tomorrow :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing fix @DominikGuzei ! 👍
This PR tries to solve an issue on Windows where an existing cardano-node sometimes cannot be killed by using normal
process.kill(pid)
because of a known issue in node.js.Review Checklist:
Basics
yarn run test
)yarn run dev
)yarn run package
/ CI builds)yarn run flow:test
)yarn run lint
)yarn run manage:translations
produces no changes)yarn run storybook
)yarn.lock
file is updatedCode Quality
Testing
After Review:
done
on the Youtrack board