Release/0.12.0 #1130
Merged
Release/0.12.0 #1130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trouble-connecting-notification [DDW-426] Fix Having Trouble Connecting Notification
…ss detection logic
[DEVOPS-1084] fix unicode in uninstaller
…transaction-fee-calculation-errors [DDW-427] Handle new transaction fee calculation error messages
…github.com/input-output-hk/daedalus into fix/ddw-432-implement-nodeipc-improvements
…om:input-output-hk/daedalus into fix/ddw-432-implement-nodeipc-improvements
…github.com/input-output-hk/daedalus into fix/ddw-432-implement-nodeipc-improvements
…odeipc-improvements [DDW-432] Implement NodeIPC improvements
Release 0.12 cardano bump
…has just woken up from sleep
…I during Cardano shutdown sequence
…-check-handling-on-system-wake-up-event [DDW-518, DDW-519, DDW-520, DDW-521] Improve NTP check handling on system wake-up event
nikolaglumac
requested review from
thedanheller,
DominikGuzei,
darko-mijic,
rvl,
deepfire and
cleverca22
DominikGuzei
previously approved these changes
Dec 12, 2018
…ion-failing [DDW-526] ADA redemption failing on Daedalus 0.12.0 with Cardano 2.0.0
1214: [DEVOPS] inital bors.toml for daedalus release branch r=disassembler a=disassembler Adds bors integration to release branch ## Todo: - [ ] Todo - [ ] Todo - [ ] Todo ## Screenshots: - Screenshot --- ## Review Checklist: ### Basics - [ ] PR is updated to the most recent version of target branch (and there are no conflicts) - [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes - [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub - [ ] Automated tests: All acceptance tests are passing (`yarn run test`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`yarn run dev`) - [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`yarn run package` / CI builds) - [ ] There are no *flow* errors or warnings (`yarn run flow:test`) - [ ] There are no *lint* errors or warnings (`yarn run lint`) - [ ] Text changes are proofread and approved (Jane Wild) - [ ] There are no missing translations (running `yarn run manage:translations` produces no changes) - [ ] UI changes look good in all themes (Alexander Rukin) - [ ] Storybook works and no stories are broken (`yarn run storybook`) - [ ] In case of dependency changes `yarn.lock` file is updated ### Code Quality - [ ] Important parts of the code are properly documented and commented - [ ] Code is properly typed with flow - [ ] React components are split-up enough to avoid unnecessary re-rendering - [ ] Any code that only works in Electron is neatly separated from components ### Testing - [ ] New feature / change is covered by acceptance tests - [ ] All existing acceptance tests are still up-to-date - [ ] New feature / change is covered by Daedalus Testing scenario - [ ] All existing Daedalus Testing scenarios are still up-to-date ### After Review: - [ ] Merge PR - [ ] Delete source branch - [ ] Move ticket to `done` on the Youtrack board Co-authored-by: Samuel Leathers <[email protected]>
darko-mijic
approved these changes
Dec 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
0.12.0
Features
certandkeywith API requests in order to enable 2-way TLS authentication (PR 1072)NetworkStatusstore to use V1 API data (PR 1081)Fixes
Chores
NETWORKinfo to the application title bar (PR 1174)cardano-node.logsince it was not needed for the support and it was impacting performance (PR 1027)npmdependencies and update script names (PR 1014)NumericInputcomponent carrot positioning issues (PR 1172)nodelLogPathentry inlauncher-config.yamloptional (PR 1027)portandcaof Ada Api configurable during runtime (PR 1067)exportandimportfeatures for the "Testnet" network (PR 1168)npmtoyarn(PR 989)