[DDW-274] Finish UI for node IPC #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikGuzei
changed the title
…ub.com/input-output-hk/daedalus into feature/ddw-274-finish-ui-for-node-ipc
disassembler
previously approved these changes
Sep 5, 2018
| @@ -0,0 +1,9 @@ | |||
| { name = "demo" | |||
| , keyPrefix = "TODO, default without the suffix" | |||
| , relays = "TODO, ip support missing" | |||
There was a problem hiding this comment.
IP and custom port support
| , reportServer = "http://staging-report-server.awstest.iohkdev.io:8080" | ||
| , installDirectorySuffix = " Demo" | ||
| , macPackageSuffix = "Demo" | ||
| , walletPort = 8092 |
There was a problem hiding this comment.
why 8092? demo cluster defaults to 8090, and I think 8092 is reserved for staging in daedalus itself when IPC isn't in play.
| , autoStartBackend ? false | ||
| , systemStart ? null |
There was a problem hiding this comment.
maybe use runCommand to get current time and add 60 seconds so users don't have to specify?
nikolaglumac
changed the title
… cardano-node state
disassembler
force-pushed
the
feature/ddw-274-finish-ui-for-node-ipc
branch
from
c5ca6aa to
d45571e
Compare
31 tasks
…r Daedalus before starting new cardano-node. Condenses set and get methods into 2 flexible methods.
…274-refactor-ipc-logic
…ipc-logic [DDW-274] Refactor IPC channels logic
31 tasks
nikolaglumac
approved these changes
Oct 3, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the necessary logic to control cardano-node from Daedalus and communicate over IPC, based on the MVP done in #893
Review Checklist:
Basics
yarn run test)yarn run dev)yarn run package/ CI builds)yarn run flow:test)yarn run lint)yarn run manage:translationsproduces no changes)yarn run storybook)yarn.lockfile is updatedCode Quality
Testing
After Review:
doneon the Youtrack board