Skip to content
This repository has been archived by the owner on Aug 18, 2020. It is now read-only.

Actually remove the 'cardano-wallet' dep from 'cardano-sl-cluster' -_-' #3935

Merged
merged 1 commit into from
Dec 6, 2018
Merged

Actually remove the 'cardano-wallet' dep from 'cardano-sl-cluster' -_-' #3935

merged 1 commit into from
Dec 6, 2018

Conversation

KtorZ
Copy link
Contributor

@KtorZ KtorZ commented Dec 6, 2018

Description

Oopsie 🙃

Linked issue

cardano-foundation/cardano-wallet#65

Type of change

  • 🐞 Bug fix (non-breaking change which fixes an issue)
  • 🛠 New feature (non-breaking change which adds functionality)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)
  • 🏭 Refactoring that does not change existing functionality but does improve things like code readability, structure etc
  • 🔨 New or improved tests for existing code
  • ⛑ git-flow chore (backport, hotfix, etc)

Developer checklist

  • I have read the style guide document, and my code follows the code style of this project.
  • If my code deals with exceptions, it follows the guidelines.
  • I have updated any documentation accordingly, if needed. Documentation changes can be reflected in opening a PR on cardanodocs.com, amending the inline Haddock comments, any relevant README file or one of the document listed in the docs directory.
  • CHANGELOG entry has been added and is linked to the correct PR on GitHub.

Testing checklist

  • I have added tests to cover my changes.
  • All new and existing tests passed.

QA Steps

Screenshots (if available)

How to merge

Send the message bors r+ to merge this PR. For more information, see
docs/how-to/bors.md.

@KtorZ KtorZ self-assigned this Dec 6, 2018
@KtorZ KtorZ requested a review from deepfire December 6, 2018 10:13
@KtorZ KtorZ mentioned this pull request Dec 6, 2018
Closed
@KtorZ KtorZ force-pushed the KtorZ/decouple-cluster-and-wallet branch from 78e52e5 to d6aa0d0 Compare December 6, 2018 10:27
deepfire
deepfire approved these changes Dec 6, 2018
View reviewed changes
Copy link
Contributor

@deepfire deepfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@deepfire
Copy link
Contributor

deepfire commented Dec 6, 2018

bors r+

iohk-bors bot added a commit that referenced this pull request Dec 6, 2018
@iohk-bors @KtorZ
Merge #3935
fc75435 
3935: Actually remove the 'cardano-wallet' dep from 'cardano-sl-cluster' -_-' r=deepfire a=KtorZ

## Description

Oopsie 🙃 

## Linked issue

cardano-foundation/cardano-wallet#65



Co-authored-by: KtorZ <[email protected]>
@iohk-bors
Copy link
Contributor

iohk-bors bot commented Dec 6, 2018

Build succeeded

@iohk-bors iohk-bors bot merged commit d6aa0d0 into develop Dec 6, 2018
@iohk-bors iohk-bors bot deleted the KtorZ/decouple-cluster-and-wallet branch December 6, 2018 14:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deepfire deepfire deepfire approved these changes

Assignees

@KtorZ KtorZ

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KtorZ @deepfire