-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add build instructions for the http bridge in CI #65
Conversation
a130dbc
to
6d3ae60
Compare
6d3ae60
to
25f8033
Compare
67e2931
to
5b4a2be
Compare
.travis.yml
Outdated
@@ -13,9 +13,10 @@ env: | |||
- EXECUTABLE=$HOME/.local/bin/cardano-wallet-server | |||
- EXECUTABLE_CHECKSUM=$HOME/.local/bin/cardano-wallet-server.sha256 | |||
- STACK_WORK_CACHE=$HOME/.local/stack-work.tar.gz | |||
- PATH=$PATH:$HOME/.cargo/bin | |||
|
|||
# Do not choose a language; we provide our own build tools: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
# Do not choose a language; we provide our own build tools: | |
# Use the Travis Rust build tools for cardano-http-bridge. | |
# Provide our own Haskell build tools for cardano-wallet. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch 👍
so why Tests on CI has failed? |
This is what I am trying to figure out. I made another round of testing yesterday, completely clearing the cache, and it seems that I broke something 🤔 ... Will figure it out.. |
5b4a2be
to
6834766
Compare
that's strange :
There is no
There is some caching problem out there as @KtorZ underlined |
e3addfc
to
7c74c51
Compare
Ok, I figured. We can't actually have two parallels jobs which share the same cache. I hoped Travis would be "smart enough" to merge the cache when there are uploads to the cache from different sources, but it doesn't. So, the job building the http bridge was finishing first, uploading his cache and then, got overwritten by the job that compiles the haskell sources. In the next stage, only the latter cache was available, which doesn't contain the Since there's now only job uploading to the cache, no more race-condition and cache overwriting. |
7c74c51
to
6ddd53b
Compare
3935: Actually remove the 'cardano-wallet' dep from 'cardano-sl-cluster' -_-' r=deepfire a=KtorZ ## Description Oopsie 🙃 ## Linked issue cardano-foundation/cardano-wallet#65 Co-authored-by: KtorZ <[email protected]>
Issue Number
#5
Overview
Comments
The http-bridge is now built within the "Compiling" job, before the Haskell code -- if not already present (so, only on the first run).
Before tests run, we now do a
cardano-http-bridge --help
which resolves correctly and proves that the bridge is available in scope for testing.