This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Alexander Vieth introduced logging in IO with ‘Trace’ in module ‘networking’. Logging does not depend on a monad in the context but is directly done using a passed-in function. This type of logging showed to be very effective, and our computation does not need to be run in a logging monad (on top of the other monads).
The implementation of ‘Pos.Util.Trace.Named’ and its tests reside in module ‘util’. No current code will use this functions.
This PR depends on PR #3476 and PR #3477. Once they are merged,
CI
tests should succeed.Linked issue
CBR-213
CBR-97 (user story)
Type of change
Developer checklist
Testing checklist
QA Steps
No changes to existing code; new code to module ‘util’