This repository has been archived by the owner on Aug 18, 2020. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In total 163 source code files import ‘System.Wlog’ directly from ‘log-warper’ and 16 modules in cardano-sl link to this library (as indicated in their cabals). We want to reduce the dependency on this external library.
As a first step we introduce module ‘Pos.Util.Wlog’ in ‘util’ that exports all of ‘System.Wlog’ and change the import statement in all 163 source files.
This way we can get rid of the direct dependency on ‘log-warper’ in ‘cardano-sl’ modules and only refer to it from module ‘util’.
Linked issue
https://iohk.myjetbrains.com/youtrack/issue/CBR-207
Type of change
Developer checklist
Testing checklist
QA Steps
Screenshots (if available)