Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for use of exactOptionalPropertyTypes: true #842

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

jpwilliams
Copy link
Member

@jpwilliams jpwilliams commented Feb 10, 2025

Summary

Fixes #836, allowing for use of exactOptionalPropertyTypes: true for type comparisons when serving.

Checklist

  • Added a docs PR that references this PR N/A Bug fix
  • Added unit/integration tests N/A We need some config-specific tests for this
  • Added changesets if applicable

Related

@jpwilliams jpwilliams added the Bug Something isn't working label Feb 10, 2025
@jpwilliams jpwilliams self-assigned this Feb 10, 2025
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 5c76d6b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
inngest Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@inngest-release-bot inngest-release-bot added the 📦 inngest Affects the `inngest` package label Feb 10, 2025
@jpwilliams jpwilliams added the prerelease/inngest Create snapshot releases for a PR for the "inngest" package. label Feb 10, 2025
@inngest-release-bot
Copy link
Collaborator

A user has added the prerelease/inngest label, so this PR will be published to npm with the tag pr-842. It will be updated with the latest changes as you push commits to this PR.

You can install this prerelease version with:

npm install inngest@pr-842

The last release was built and published from 5c76d6b.

@jpwilliams jpwilliams merged commit 4237efd into main Feb 11, 2025
64 checks passed
@jpwilliams jpwilliams deleted the fix-like-exact-optional-types branch February 11, 2025 12:55
jpwilliams pushed a commit that referenced this pull request Feb 11, 2025
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## [email protected]

### Patch Changes

- [#842](#842)
[`4237efd`](4237efd)
Thanks [@jpwilliams](https://github.com/jpwilliams)! - Allow for use of
`exactOptionalPropertyTypes: true` when serving

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working 📦 inngest Affects the `inngest` package prerelease/inngest Create snapshot releases for a PR for the "inngest" package.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Type error when trying to serve Inngest functions on version 3.31.1
2 participants