Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add _getTextboxValueFromOption method #1377

Merged

Conversation

MatthieuLebigre
Copy link
Contributor

What I did

This PR aims to fix this discussion: #1247

@changeset-bot
Copy link

changeset-bot bot commented May 11, 2021

🦋 Changeset detected

Latest commit: 6cdefd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@lion/combobox Minor
@lion/form-integrations Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Collaborator

@jorenbroekema jorenbroekema left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just adding tests and running npm run format so prettier doesn't complain :). Thanks for creating the PR!

@MatthieuLebigre
Copy link
Contributor Author

Mostly just adding tests and running npm run format so prettier doesn't complain :). Thanks for creating the PR!

For prettier, when I run npm run format it modifies a bunch of files, but not the one I've changed :D Have you already experienced that?

@tlouisse
Copy link
Member

tlouisse commented May 17, 2021

Mostly just adding tests and running npm run format so prettier doesn't complain :). Thanks for creating the PR!

For prettier, when I run npm run format it modifies a bunch of files, but not the one I've changed :D Have you already experienced that?

It appears that different configs of the Prettier vscode plugin can explain those differences (even though they take .eslintrc, prettier config in package.json into consideration.)
Not sure yet what 'wins' and when and how we can best mitigate this problem

@MatthieuLebigre
Copy link
Contributor Author

Mostly just adding tests and running npm run format so prettier doesn't complain :). Thanks for creating the PR!

For prettier, when I run npm run format it modifies a bunch of files, but not the one I've changed :D Have you already experienced that?

It appears that different configs of the Prettier vscode plugin can explain those differences (even though they take .eslintrc, prettier config in package.json into consideration.)
Not sure yet what 'wins' and when and how we can best mitigate this problem

I tried a lot of different options/configuration but it doesn't work. I tried turning off the VSCode plugin, changing the config to a .prettierrc file, but it changes nothing :(

Copy link
Member

@tlouisse tlouisse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe you can reapply the tests with prettier disabled? Then we can review the tests better.
The formatting inconsistencies could be tackled in a separate issue.

@MatthieuLebigre MatthieuLebigre force-pushed the feat/combobox-complex-object branch from 904e887 to b2fd0fb Compare May 19, 2021 19:54
@MatthieuLebigre MatthieuLebigre force-pushed the feat/combobox-complex-object branch from b2fd0fb to 92d5e61 Compare May 20, 2021 15:56
@tlouisse tlouisse force-pushed the feat/combobox-complex-object branch from 92d5e61 to 6cdefd8 Compare May 20, 2021 21:59
@tlouisse
Copy link
Member

Everything is solved 👍 Thanks for this contribution

@tlouisse tlouisse dismissed jorenbroekema’s stale review May 20, 2021 22:07

issues are resolved

@tlouisse tlouisse merged commit c4af8a9 into ing-bank:master May 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants