-
Notifications
You must be signed in to change notification settings - Fork 308
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add _getTextboxValueFromOption method #1377
feat: add _getTextboxValueFromOption method #1377
Conversation
🦋 Changeset detectedLatest commit: 6cdefd8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly just adding tests and running npm run format
so prettier doesn't complain :). Thanks for creating the PR!
For prettier, when I run |
It appears that different configs of the Prettier vscode plugin can explain those differences (even though they take .eslintrc, prettier config in package.json into consideration.) |
I tried a lot of different options/configuration but it doesn't work. I tried turning off the VSCode plugin, changing the config to a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can reapply the tests with prettier disabled? Then we can review the tests better.
The formatting inconsistencies could be tackled in a separate issue.
904e887
to
b2fd0fb
Compare
b2fd0fb
to
92d5e61
Compare
92d5e61
to
6cdefd8
Compare
Everything is solved 👍 Thanks for this contribution |
What I did
This PR aims to fix this discussion: #1247