Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API cleanup #47

Merged
merged 3 commits into from
Mar 24, 2023
Merged

API cleanup #47

merged 3 commits into from
Mar 24, 2023

Commits on Mar 23, 2023

  1. Remove global scope checks from permissions-api 

    Roles are to be tenant-scoped by design for MVP. We can consider
adding global scope in the future, but for now to keep things simple
we're just going to have tenant roles.

Signed-off-by: John Schaeffer <[email protected]>
    @jnschaeffer
    jnschaeffer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    a573f4b View commit details
    Browse the repository at this point in the history

  2. Remove resource availability check 

    Checking the available resources for a given subject isn't in scope
for MVP, so we're removing it for now. Since it's in history we should
be able to pull this back in if/as needed.

Signed-off-by: John Schaeffer <[email protected]>
    @jnschaeffer
    jnschaeffer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    0956c6c View commit details
    Browse the repository at this point in the history

  3. Remove resource update, simplify schema 

    To simplify things further for MVP, resource update has been removed
and the schema has been substantially simplified. Built-in roles are
good, and we should support them, but just to keep things simple for
now they have been removed. We can reintroduce them once we're
confident in the design so far.

Signed-off-by: John Schaeffer <[email protected]>
    @jnschaeffer
    jnschaeffer committed Mar 23, 2023
    Configuration menu
    Copy the full SHA
    c369110 View commit details
    Browse the repository at this point in the history