API cleanup #47
Merged
API cleanup #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Roles are to be tenant-scoped by design for MVP. We can consider adding global scope in the future, but for now to keep things simple we're just going to have tenant roles. Signed-off-by: John Schaeffer <[email protected]>
Checking the available resources for a given subject isn't in scope for MVP, so we're removing it for now. Since it's in history we should be able to pull this back in if/as needed. Signed-off-by: John Schaeffer <[email protected]>
To simplify things further for MVP, resource update has been removed and the schema has been substantially simplified. Built-in roles are good, and we should support them, but just to keep things simple for now they have been removed. We can reintroduce them once we're confident in the design so far. Signed-off-by: John Schaeffer <[email protected]>
JAORMX
approved these changes
Mar 24, 2023
JAORMX
added a commit
to JAORMX/permissions-api
that referenced
this pull request
Mar 24, 2023
A recent PR (infratographer#47) simplified the API endpoints and schema. This reflects the change in the client by removing the API calls that are no longer applicable. This also removes the explicit setting of the token in favor of using a ready-to-go http.Client instance such as the one that https://pkg.go.dev/golang.org/x/oauth2#section-readme may provide. Signed-off-by: Juan Antonio Osorio <[email protected]>
jnschaeffer
pushed a commit
that referenced
this pull request
Mar 24, 2023
A recent PR (#47) simplified the API endpoints and schema. This reflects the change in the client by removing the API calls that are no longer applicable. This also removes the explicit setting of the token in favor of using a ready-to-go http.Client instance such as the one that https://pkg.go.dev/golang.org/x/oauth2#section-readme may provide. Signed-off-by: Juan Antonio Osorio <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes most functionality that isn't strictly necessary to accomplish permissions checking and resource registration. In particular, the following changes were made:
Some or all of this functionality may be added back in future PRs as needs dictate. For now, the goal is primarily to start with what we believe we need and build out from there. Manual testing shows that permissions checks resolve as expected.