-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release v0.17.0 #751
Release v0.17.0 #751
Conversation
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
Is it still possible to get one last minute change in? I'd like to cut another breaking release of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As I mentioned in our discussion, I would rather have a 0.16.0 -> 0.17.0 full changelog on top of the rc release changelogs (we should keep those too), just so we see all the changes going into the new release but it's just a personal preference.
Thanks for the doctest improvements and the contribution file additions!
Codecov Report
@@ Coverage Diff @@
## master #751 +/- ##
========================================
- Coverage 43.3% 42.1% -1.2%
========================================
Files 203 206 +3
Lines 13169 13945 +776
Branches 3483 3571 +88
========================================
+ Hits 5705 5876 +171
- Misses 7104 7695 +591
- Partials 360 374 +14
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome work.
I opened a PR to bump the If it's possible to get that PR into this release, that'd be great! |
Signed-off-by: Thane Thomson <[email protected]>
d2429c4
Signed-off-by: Thane Thomson <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool stuff. Made some suggestions to make it a bit more concise but they're not that important.
Co-authored-by: Greg Szabo <[email protected]>
Co-authored-by: Greg Szabo <[email protected]>
Co-authored-by: Greg Szabo <[email protected]>
Co-authored-by: Greg Szabo <[email protected]>
Signed-off-by: Thane Thomson <[email protected]>
…inuing Signed-off-by: Thane Thomson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Script looks good. I like that it has a timeout.
📖 CHANGELOG
📖 New "Releases" section in contributing guidelines