Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump k256 crate dependency to v0.6 #724

Merged
merged 1 commit into from
Dec 7, 2020
Merged

Bump k256 crate dependency to v0.6 #724

merged 1 commit into from
Dec 7, 2020

Conversation

tony-iqlusion
Copy link
Collaborator

@codecov-io
Copy link

Codecov Report

Merging #724 (d2c7958) into master (68bb2e8) will decrease coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #724     +/-   ##
========================================
- Coverage    42.7%   42.6%   -0.2%     
========================================
  Files         202     202             
  Lines       12858   12901     +43     
  Branches     3223    3298     +75     
========================================
  Hits         5496    5496             
- Misses       7014    7055     +41     
- Partials      348     350      +2     
Impacted Files Coverage Δ
tendermint/src/public_key.rs 56.7% <0.0%> (-4.7%) ⬇️
light-client/src/components/verifier.rs 91.1% <0.0%> (-3.0%) ⬇️
light-node/src/rpc.rs 52.0% <0.0%> (-1.5%) ⬇️
light-client/tests/light_client.rs 86.0% <0.0%> (-1.3%) ⬇️
tendermint/src/account.rs 79.0% <0.0%> (-1.3%) ⬇️
rpc/src/client/transport/router.rs 74.1% <0.0%> (-0.9%) ⬇️
testgen/src/commit.rs 78.9% <0.0%> (-0.8%) ⬇️
light-client/src/tests.rs 69.0% <0.0%> (-0.8%) ⬇️
light-client/tests/model_based.rs 87.6% <0.0%> (-0.7%) ⬇️
testgen/src/light_block.rs 82.0% <0.0%> (-0.7%) ⬇️
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68bb2e8...d2c7958. Read the comment docs.

@tony-iqlusion
Copy link
Collaborator Author

Note: this release adds a k256::PublicKey type which ensures public keys are valid secp256k1 curve points:

https://docs.rs/elliptic-curve/0.7.1/elliptic_curve/public_key/struct.PublicKey.html

It might make sense to switch to it, however that'd also require changing the current tendermint::PublicKey::as_bytes() method (which borrows) to a ::to_bytes() method which allocates / returns something like Vec<u8>, as the k256::PublicKey type does not retain the encoded form.

@xla
Copy link
Contributor

xla commented Dec 7, 2020

It might make sense to switch to it, however that'd also require changing the current tendermint::PublicKey::as_bytes() method (which borrows) to a ::to_bytes() method which allocates / returns something like Vec<u8>, as the k256::PublicKey type does not retain the encoded form.

@tony-iqlusion Do you have any intuition what the cost would be for this change?

Copy link
Contributor

@xla xla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

👑 🍊 🚆 ♒️

@tarcieri tarcieri merged commit 1892b69 into master Dec 7, 2020
@tarcieri tarcieri deleted the k256/v0.6 branch December 7, 2020 16:22
@tony-iqlusion tony-iqlusion mentioned this pull request Dec 16, 2020
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants