Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing #469

Closed
wants to merge 61 commits into from
Closed

Contributing #469

wants to merge 61 commits into from

Conversation

brapse
Copy link
Contributor

@brapse brapse commented Jul 22, 2020

We need a minimal CONTRIBUTING file for #323.
This ports over most of the one from tendermint and is probably missing a bunch of stuff but is hopefully a start.

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

@andrey-kuprianov
mbt/tendermint-produce validator
56396ce
@andrey-kuprianov
add constructor for ProposerPriority
c5d6506
@andrey-kuprianov
mbt-utils/produce header (not complete yet)
19d0a3c
@andrey-kuprianov
better error handling
38c9d80
@andrey-kuprianov
add default_consensus_params(); not clear how to correctly hash it
e6bcaf7
@andrey-kuprianov
mbt-utils-produce: started on commit
ae2c189
@andrey-kuprianov
read input using generic function
d2ff698
@andrey-kuprianov
mbt-utils: rework produce_validator to accept input id/input JSON/CLI…
53cdb24 
… options
@andrey-kuprianov
use serde deserializers for option fields
03314db
@andrey-kuprianov
mbt-utils/produce-header: allow to set next_vals/time via input/cli
d1eb8b1
@andrey-kuprianov
mbt-utils/produce-header: remove debug output
db8fb01
@andrey-kuprianov
Merge branch 'master' into andrey/mbt-utils
1884cd6
@andrey-kuprianov
mbt-utils: refactor produce validator
a3a9505 
* refactor produce_validator to allow calling it from within Rust code,
to easily produce Info struct
* add --ignore-stdin option to allow skipping parsing from STDIN
@andrey-kuprianov
mbt-utils: refactor produce header
6883b0c
@andrey-kuprianov
mbt-utils/produce-header: allow to specify header height
d13ca00
@andrey-kuprianov
mbt-utils/produce-commit: refactor + add height
7bfb115
@andrey-kuprianov
started refactoring using traits; added --usage
8bdfad6
@andrey-kuprianov
better help
9b5541c
@andrey-kuprianov
mbt-utils/move produce header into Producer trait
457d518
@andrey-kuprianov
mbt-utils/move produce commit into Producer trait
976c1e1
@andrey-kuprianov
minor improvements
f912290
@andrey-kuprianov
mbt-utils: produce commit from header
9cb876f
@andrey-kuprianov
mbt-utils: add generator functions for Validator,Header,Commit
b41ee56
@andrey-kuprianov
mbt-utils: simplify Producer interface
5f93b20
@andrey-kuprianov
mbt-utils: make stdin parsing failable
21aac34
@andrey-kuprianov
mbt-utils: pull up signer from Validator::produce()
dd07802
@andrey-kuprianov
mbt-utils: started on producing real signatures for commits
be1c8aa
@andrey-kuprianov
mbt-utils: small simplification
552d2c9
@andrey-kuprianov
Merge branch 'master' into andrey/mbt-utils
b99e1a7
@andrey-kuprianov
Merge branch 'master' into andrey/mbt-utils
100a19b
romac and others added 27 commits July 6, 2020 16:21
@romac
Refactor into a library and a binary
3666003
@romac
Move tendermint-produce command into bin/ directory
b123724
@romac
Remove newline at end of files
c86fdcd
@andrey-kuprianov
Merge pull request #411 from informalsystems/romain/mbt-utils
19b0762 
Turn `mbt-utils` crate into a library
@andrey-kuprianov
mbt-utils: start refactoring, FromStr for Validator, Commit, Header
a406414
@andrey-kuprianov
mbt-utils: move encode_with_stdin out of Producer trait
edebadf
@andrey-kuprianov
mbt-utils: remove parse_stdin() from Producer/Validator/Commit/Header
56b4aa4
@andrey-kuprianov
mbt:utils: get rid of unwraps for better error handling
17d49d7
@andrey-kuprianov
#393: refactor mbt-tendermint-produce into tendermint-typegen
00b102f
@andrey-kuprianov
#393: change in usage mbt-tendermint-produce into tendermint-typegen
ffaa039
@andrey-kuprianov
#393: switch to gen_setter macros for setters
19dd8be
@andrey-kuprianov
#393: start on vote
00d1445
@andrey-kuprianov
#393: tendermint-typegen -> tendermint-testgen
280e822
@andrey-kuprianov
#393: more of vote + shorten code
ede2e45
@andrey-kuprianov
#393: shorten imports
4991c0d
@andrey-kuprianov
#393: add generation of votes; refactor commit
56a11d8
@andrey-kuprianov
#393: commit: use getters
54651f2
@andrey-kuprianov
#393: finish code restructuring
ef84f20
@andrey-kuprianov
#393: validator unit test
61dc01f
@andrey-kuprianov
#393: header unit test
8fed686
@andrey-kuprianov
Merge branch 'master' into andrey/mbt-utils
959d4ac
@andrey-kuprianov
#393: rename mbt-utils -> tendermint-testgen
6301089
@andrey-kuprianov
#393: more tests for validator and header
3e31f4a
@andrey-kuprianov
#393: unit test for vote
7a86b53
@andrey-kuprianov
#393: unit test for commit; factor out sign/verify helpers
feffb1b
@andrey-kuprianov
#393: fix clippy warnings
5d648ff
@brapse
initial attempt at porting the CONTRIBUTING.md
484a2db
@brapse
Copy link
Contributor Author

brapse commented Jul 22, 2020

This was a mistake, wrong base branch. 🤦

@brapse brapse closed this Jul 22, 2020
@brapse brapse deleted the brapse/initial-contributing branch July 22, 2020 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@brapse @andrey-kuprianov @romac