Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn mbt-utils crate into a library #411

Merged
merged 6 commits into from
Jul 6, 2020
Merged

Turn mbt-utils crate into a library #411

merged 6 commits into from
Jul 6, 2020

Conversation

romac
Copy link
Member

@romac romac commented Jul 6, 2020

  • Referenced an issue explaining the need for the change
  • Updated all relevant documentation in docs
  • Updated all code comments where relevant
  • Wrote tests
  • Updated CHANGES.md

andrey-kuprianov
andrey-kuprianov approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@andrey-kuprianov andrey-kuprianov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the nice refactoring, Romain! I really wanted to do exactly this, but as I am not yet very good with Rust was postponing the step;)

@andrey-kuprianov andrey-kuprianov merged commit 19b0762 into andrey/mbt-utils Jul 6, 2020
@andrey-kuprianov andrey-kuprianov deleted the romain/mbt-utils branch July 6, 2020 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrey-kuprianov andrey-kuprianov andrey-kuprianov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@romac @andrey-kuprianov