fix(demo): hotrod was broken #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the demo, the hotrod app was emitting trace events without attributes, including name. It seems that is related to this PR: jaegertracing/jaeger#4187 For now, the easy fix is to rollback hotrod to Jaeger version 1.41.
jacobmarble
force-pushed
the
jgm-unbreak-hotrod
branch
from
55f90ee
to
eb1bfc6
Compare
domodwyer
approved these changes
Apr 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the demo, the hotrod app was emitting trace events without attributes, including name. It seems that is related to this PR: jaegertracing/jaeger#4187
For now, the easy fix is to rollback hotrod to Jaeger version 1.41.