-
Notifications
You must be signed in to change notification settings - Fork 23
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
In the demo, the hotrod app was emitting trace events without attributes, including name. It seems that is related to this PR: jaegertracing/jaeger#4187 For now, the easy fix is to rollback hotrod to Jaeger version 1.41.
- Loading branch information
1 parent
83c29ff
commit 971e470
Showing
4 changed files
with
18 additions
and
18 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,18 +1,13 @@ | ||
--- a/examples/hotrod/cmd/root.go | ||
+++ b/examples/hotrod/cmd/root.go | ||
@@ -98,12 +98,9 @@ func onInitialize() { | ||
@@ -81,7 +81,9 @@ func init() { | ||
RootCmd.PersistentFlags().StringVarP(&jaegerUI, "jaeger-ui", "j", "http://localhost:16686", "Address of Jaeger UI to create [find trace] links") | ||
|
||
rand.Seed(int64(time.Now().Nanosecond())) | ||
- logger, _ = zap.NewDevelopment( | ||
+ loggerConfig := zap.NewProductionConfig() | ||
+ loggerConfig.Level.SetLevel(zapcore.FatalLevel) | ||
+ logger, _ = loggerConfig.Build( | ||
zap.AddStacktrace(zapcore.FatalLevel), | ||
zap.AddCallerSkip(1), | ||
} | ||
- if !verbose { | ||
- zapOptions = append(zapOptions, | ||
- zap.IncreaseLevel(zap.LevelEnablerFunc(func(l zapcore.Level) bool { return l != zapcore.DebugLevel })), | ||
- ) | ||
- } | ||
- logger, _ = zap.NewDevelopment(zapOptions...) | ||
+ loggerConfig := zap.NewProductionConfig() | ||
+ loggerConfig.Level.SetLevel(zapcore.ErrorLevel) | ||
+ logger, _ = loggerConfig.Build(zapOptions...) | ||
|
||
jaegerclientenv2otel.MapJaegerToOtelEnvVars(logger) | ||
|
||
) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters