FI-3367 Disable TLS from Env #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/tls_test_kit/tls_version_test.rb
Outdated
| @@ -70,6 +70,7 @@ def incorrectly_permitted_tls_version_message_type | |||
| input :url | |||
|
|
|||
| run do | |||
| omit_if ENV['INFERNO_DISABLE_TLS_TEST'], "This test is disabled because INFERNO_DISABLE_TLS_TEST is present in env." | |||
There was a problem hiding this comment.
They should have to set it to true. As an example (although this one defaults to true instead of false):
Jammjammjamm
approved these changes
Oct 28, 2024
This was referenced Oct 28, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If
INFERNO_DISABLE_TLS_TESTis in env the test will mark itself asomit.Testing Guidance
bundle exec inferno services startINFERNO_DISABLE_TLS_TEST=true bundle exec inferno start