FI-2727 Initial Implementation of Inferno (g)(10) Test Kit into CI #182
Conversation
Shaumik-Ashraf
changed the title
.github/workflows/inferno_ci.yml
Outdated
| bulk_patient_ids_in_group:85,355 \ | ||
| "smart_credentials:{\"access_token\":\"SAMPLE_TOKEN\"}" | ||
|
|
||
| - name: Run g10 test kit Single Patient API with US Core 6.1.0 |
There was a problem hiding this comment.
If the 3.1.1 tests fail then this won't run and it could possibly hide a failure here as well. How would you feel about using a matrix with the different US core versions? https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/running-variations-of-jobs-in-a-workflow
There was a problem hiding this comment.
I agree, but doing this as a matrix is another ticket (FI-3373)
There was a problem hiding this comment.
If you want to push this update to later, please update that other ticket so that it isn't just about doing more combos but it is ALSO about not halting on the first version that fails, which I agree would be annoying from a development planning perspective. I didn't realize that is how this works.
|
Ready for re-review and merge! |
Could you just quickly reply with what you did (if anything) in the above comment threads @Shaumik-Ashraf to expedite review? |
Co-authored-by: Dylan Hall <[email protected]>
I'll summarize here:
|
Summary
This PR is the culmination of work based off of various other branches and PRs (see #167, #180, inferno-framework/inferno-core#540, inferno-framework/inferno-core#542, inferno-framework/inferno-core#550, inferno-framework/tls-test-kit#20, onc-healthit/onc-certification-g10-test-kit#577). It utilizes the new
inferno executeCLI to run Inferno tests in CI, and developers may look at the.github/workflows/inferno_ci.ymlfile as reference to implement their own CI pipelines.Please note the current implementation has a few limitations, and certain tests such as TLS tests and SMART launch cannot be emulated in a typical CI environment. This PR's implementation currently disables TLS tests with the
INFERNO_DISABLE_TLS_TESTenvironment variable. We are looking for better methods to properly integration test the remaining (g)(10) test kit and other Inferno test kit features.New behavior
The following components of the ONC Certification (g)(10) Test Kit will now run as a GitHub Action Continuous Integration test on the Inferno Reference Server:
Code changes
Replace the
wait-for-itscript withwait-for, clean up old GitHub Action files, and implement the new.github/workflows/inferno_ci.ymlfile.Testing guidance
Observe Github Actions result for Inferno CI workflow.