Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2824 - Layer name with special characters causes problems in search #5046

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

reckart
Copy link
Member

@reckart reckart commented Sep 7, 2024

What's in the PR

  • Add shortName field to the DB
  • Add shortName field to the AnnotationLayer entity
  • Add mechanism into AnnotaitonLayer entity to fall back to the UIMA short name (i.e. part of name after last dot)
  • Add shortName field to the layer detail form
  • Add validation for the shortName field to ensure it is compatible with the field name conventions required by the index
  • Add shortName to export DTO
  • Use shortName when building the index
  • Should user by able to enter short name manually when creating the layer or should it be derived from the UI name just like the full UIMA name?
  • Should the short name also be used to create the UIMA name instead of deriving the short name from the UI name?

How to test manually

  • TBD

Automatic testing

  • PR includes unit tests

Documentation

  • PR updates documentation

@reckart reckart added 🐛Bug Something isn't working Module: Project Search labels Sep 7, 2024
@reckart reckart added this to the 35.0 milestone Sep 7, 2024
@reckart reckart self-assigned this Sep 7, 2024
@reckart reckart force-pushed the bug/2824-Layer-name-with-special-characters-causes-problems-in-search branch from 322cdae to bc0c2d9 Compare September 7, 2024 17:27
- Start introducing a "shortName" field in the layer which could be used to configure a name that would be compatible with the index
- Change DB schema
- Started changing layer detail form
- Other stuff still missing
@reckart reckart force-pushed the bug/2824-Layer-name-with-special-characters-causes-problems-in-search branch from bc0c2d9 to 2223419 Compare September 7, 2024 18:46
…causes-problems-in-search

* main: (32 commits)
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-34.0
  No issue: Mention MS SQL and PosgreSQL as experimental DB options
  No issue: Fix versions after merge
  #5043 - Ability to specify token breaking zones when calling tokenizer
  #5064 - Project template for PHI annotation
  #5071 - Better document which layers are supported by which formats
  #5061 - Multiple synchronous recommenders only the last one wins
  #5064 - Project template for PHI annotation
  #5068 - Show annotation sidebar by default
  #5033 - Ability to configure recommenders interactively on the annotation page
  #5066 - Increase default number of rows for brat editors
  #5056 - Ability to configure additional languages for knowledge bases
  #4909 - Upgrade dependencies
  #5056 - Ability to configure additional languages for knowledge bases
  #4909 - Upgrade dependencies
  No issue: Actually, document-metadata doesn't seem to be experimental after all...
  No issue: Set version to 35.0-SNAPSHOT
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-33.7
  ...

% Conflicts:
%	inception/inception-ui-project/src/main/java/de/tudarmstadt/ukp/clarin/webanno/ui/project/layers/ProjectLayersPanel.html
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛Bug Something isn't working Module: Project Search
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

1 participant