-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
155 add support for null params #156
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Now it is possible to explicitly declare a parameter with null value
…d `wfexs_backend.utils.contents.link_or_copy_path`
…upport multiple, read-only, cache directories
…eters (e.g. a list), pass a single path instead of a list of them
* Cached workflow sources parsing is now stored locally at the staged workflow directory, and a read-only copy is maintained in the cache directory. * As some of the nextflow plugins might not be available in the registry, instead of giving an error trying to install all the plugins at once, install them one by one, showing a warning in the cases where a plugin could not be installed.
…values. It is pending to test the representation of those null values in WRROC, and the ingestion of them once the WRROC is imported.
… from read-only cache dirs to read-write ones
…o MaterializedInput , so complex names are properly mangled and unmangled.
…me, not in runtime
Some cases, like Nextflow, have structured, nested parameters. In that scenario, it is allowed that the name of the key can contain dots. As the dot is the join character being used for linearized param names, it is important to properly quote those parameters, so they are properly managed. Also, fixed a couple of hidden bugs related to null handling and augmented parameters processing.
…as param names containing dots
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for null params, and fixed several issues related to structured parameter handling when names contained dots.