fix(mobile): improve image load cancellation handling#27624
Merged
Conversation
LeLunZ
changed the title
mertalev
reviewed
Apr 8, 2026
Member
|
I'm not sure if this fixes the thumbnail loading issue we've seen, but it addresses a race condition regardless. Interestingly, it seems to perform better than main, which is a good sign that the cancellation is behaving better with this change.
|
mertalev
approved these changes
Apr 8, 2026
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Apr 10, 2026
…3) (#128) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [immich-app/immich](https://github.com/immich-app/immich) | patch | `v2.7.2` → `v2.7.3` | --- ### Release Notes <details> <summary>immich-app/immich (immich-app/immich)</summary> ### [`v2.7.3`](https://github.com/immich-app/immich/releases/tag/v2.7.3) [Compare Source](immich-app/immich@v2.7.2...v2.7.3) ### v2.7.3 #### What's Changed ##### 🐛 Bug fixes - fix(server): avoid false restore failures on large database imports by [@​ErasmusAndre](https://github.com/ErasmusAndre) in [#​27420](immich-app/immich#27420) - fix(mobile): improve image load cancellation handling by [@​LeLunZ](https://github.com/LeLunZ) in [#​27624](immich-app/immich#27624) - fix(server): people search not showing for 3 or less characters by [@​zackpollard](https://github.com/zackpollard) in [#​27629](immich-app/immich#27629) - fix(web): don't cache empty search results for people search by [@​zackpollard](https://github.com/zackpollard) in [#​27632](immich-app/immich#27632) - fix(mobile): get provider refs before async gaps in backup page by [@​LeLunZ](https://github.com/LeLunZ) in [#​27597](immich-app/immich#27597) - fix: ssr open graph tags by [@​jrasm91](https://github.com/jrasm91) in [#​27639](immich-app/immich#27639) ##### 📚 Documentation - fix(docs): updated docker deprecation link by [@​mmomjian](https://github.com/mmomjian) in [#​27633](immich-app/immich#27633) #### New Contributors - [@​fluffy](https://github.com/fluffy) made their first contribution in [#​27606](immich-app/immich#27606) - [@​ErasmusAndre](https://github.com/ErasmusAndre) made their first contribution in [#​27420](immich-app/immich#27420) **Full Changelog**: <immich-app/immich@v2.7.2...v2.7.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/128 Co-authored-by: bot-owl <bot@erwanleboucher.dev> Co-committed-by: bot-owl <bot@erwanleboucher.dev>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Instantly evicts images from cache when we don't need them anymore.
This also means, we can't call evict again when we exit early with
isCancelledis true, as that could remove already new cache values.So I hope I didn't miss an exit condition where we can't call
evict(true).How Has This Been Tested?
Checklist:
Please describe to which degree, if any, an LLM was used in creating this pull request.
/