fix(server): avoid false restore failures on large database imports#27420
Merged
jrasm91 merged 4 commits intoimmich-app:mainfrom Apr 8, 2026
Merged
fix(server): avoid false restore failures on large database imports#27420jrasm91 merged 4 commits intoimmich-app:mainfrom
jrasm91 merged 4 commits intoimmich-app:mainfrom
Conversation
Contributor
|
This PR has been automatically closed as the description doesn't follow our template. After you edit it to match the template, the PR will automatically be reopened. |
jrasm91
approved these changes
Apr 1, 2026
insertish
approved these changes
Apr 8, 2026
eleboucher
pushed a commit
to eleboucher/homelab
that referenced
this pull request
Apr 10, 2026
…3) (#128) This PR contains the following updates: | Package | Update | Change | |---|---|---| | [immich-app/immich](https://github.com/immich-app/immich) | patch | `v2.7.2` → `v2.7.3` | --- ### Release Notes <details> <summary>immich-app/immich (immich-app/immich)</summary> ### [`v2.7.3`](https://github.com/immich-app/immich/releases/tag/v2.7.3) [Compare Source](immich-app/immich@v2.7.2...v2.7.3) ### v2.7.3 #### What's Changed ##### 🐛 Bug fixes - fix(server): avoid false restore failures on large database imports by [@​ErasmusAndre](https://github.com/ErasmusAndre) in [#​27420](immich-app/immich#27420) - fix(mobile): improve image load cancellation handling by [@​LeLunZ](https://github.com/LeLunZ) in [#​27624](immich-app/immich#27624) - fix(server): people search not showing for 3 or less characters by [@​zackpollard](https://github.com/zackpollard) in [#​27629](immich-app/immich#27629) - fix(web): don't cache empty search results for people search by [@​zackpollard](https://github.com/zackpollard) in [#​27632](immich-app/immich#27632) - fix(mobile): get provider refs before async gaps in backup page by [@​LeLunZ](https://github.com/LeLunZ) in [#​27597](immich-app/immich#27597) - fix: ssr open graph tags by [@​jrasm91](https://github.com/jrasm91) in [#​27639](immich-app/immich#27639) ##### 📚 Documentation - fix(docs): updated docker deprecation link by [@​mmomjian](https://github.com/mmomjian) in [#​27633](immich-app/immich#27633) #### New Contributors - [@​fluffy](https://github.com/fluffy) made their first contribution in [#​27606](immich-app/immich#27606) - [@​ErasmusAndre](https://github.com/ErasmusAndre) made their first contribution in [#​27420](immich-app/immich#27420) **Full Changelog**: <immich-app/immich@v2.7.2...v2.7.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4xMDEuMSIsInVwZGF0ZWRJblZlciI6IjQzLjEwMS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJyZW5vdmF0ZS9naXRodWItcmVsZWFzZSIsInR5cGUvcGF0Y2giXX0=--> Reviewed-on: https://git.erwanleboucher.dev/eleboucher/homelab/pulls/128 Co-authored-by: bot-owl <bot@erwanleboucher.dev> Co-committed-by: bot-owl <bot@erwanleboucher.dev>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I ran into an issue while migrating an Immich database backup where the database import completed, but the post-restore health check timed out, the restore flow rolled the database back, and the frontend showed
nullinstead of a useful error message.These changes increase the maintenance restore API health check timeout from 20 seconds to 180 seconds, and reject health check failures as
Errorobjects instead of raw strings.In practice, 20 seconds is too short for this validation path on larger restores. Increasing the timeout should prevent these unnecessary restore failures, and rejecting with
Errorobjects keeps the failure shape consistent for downstream handling.How Has This Been Tested?
server/src/maintenance/maintenance-health.repository.tsChecklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
LLM-assisted investigation and draft wording. The final code change was reviewed by AI before submission.