Skip to content

feat(mobile): optimize remote image request pipeline with fast-path on ios #27524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
LeLunZ wants to merge 1 commit into from
+5 −5
Closed

feat(mobile): optimize remote image request pipeline with fast-path on ios #27524

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions mobile/ios/Runner/Images/RemoteImagesImpl.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,14 +70,14 @@ class RemoteImageApiImpl: NSObject, RemoteImageApi {
return request.finish(with: .failure(PigeonError(code: "", message: "No data received", details: nil)))
}

// Return raw encoded bytes when requested (for animated images)
if encoded {
return request.finish(encoding: data)
}

ImageProcessing.queue.addOperation {
if request.isCancelled { return }

// Return raw encoded bytes when requested (for animated images)
if encoded {
return request.finish(encoding: data)
}

guard let imageSource = CGImageSourceCreateWithData(data as CFData, nil),
let cgImage = CGImageSourceCreateThumbnailAtIndex(imageSource, 0, decodeOptions) else {
return request.finish(with: .failure(PigeonError(code: "", message: "Failed to decode image for request", details: nil)))
Expand Down
Loading