feat(mobile): optimize remote image request pipeline with fast-path on ios#27524
Closed
LeLunZ wants to merge 1 commit intorefactor/ios-image-requestfrom
Closed
feat(mobile): optimize remote image request pipeline with fast-path on ios#27524LeLunZ wants to merge 1 commit intorefactor/ios-image-requestfrom
LeLunZ wants to merge 1 commit intorefactor/ios-image-requestfrom
Conversation
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Early returns a remote image request without scheduling a new operation if an encoded image was requested.
Previously if a remote image was requested, and flutter requested the encoded version we launched another thread (from the request background thread) just to return a copy of some data.
I think in such a case it doesn't really make sense to wait on an available thread. The copy is just a memory operation, and nothing cpu intensive for which we would need a new thread.
How Has This Been Tested?
@mertalev Does this need some testing? Currently we only use that for animated images in the asset viewer, so I can't even do the timeline fast scrolling tests, or some automated fast scrolling tests.
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.