feat(mobile): Add possibility to zoom on videos#26599
Closed
evanbarke wants to merge 1 commit intoimmich-app:mainfrom
Closed
feat(mobile): Add possibility to zoom on videos#26599evanbarke wants to merge 1 commit intoimmich-app:mainfrom
evanbarke wants to merge 1 commit intoimmich-app:mainfrom
Conversation
Add null check for onDoubleTap and disableScaleGestures before adding gesture recognizers.
|
Label error. Requires exactly 1 of: changelog:.*. Found: 📱mobile. A maintainer will add the required label. |
evanbarke
changed the title
evanbarke
changed the title
Author
|
This time I carefully cherry picked the AI code to make sure it was succinct and logical and I tested the APK on a real device before. This was a tricky one because on the emulator the zoom worked but the real gestures didn't on a real device |
6 tasks
Contributor
Collaborator
|
I agree @goalie2002, we have removed the nested photo view and this should no longer be an issue. There is a quirk where the native video viewer will absorb pointer events (not sure if that's a problem on main at the moment though), but it should be addressed by #26673. |
Collaborator
|
Thank you though @evanbarke, hugely appreciate you being proactive in fixes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The outer PhotoView wrapper for videos was registering a ScaleGestureRecognizer even with scale disabled, winning the gesture arena on real devices and swallowing pinch events before the inner video PhotoView could handle them.
Description
Fixes # (issue)
How Has This Been Tested?
Open a video, double tap, pinch to zoom and pan
Screenshots (if appropriate)
Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)Please describe to which degree, if any, an LLM was used in creating this pull request.
I used LLM to help me but applied the code manually
...