refactor: simplify video zooming

[shenlong-tanwen]

No description provided.

[goalie2002]

Sorry for creating a bunch of refactoring work for you guys. I did briefly consider trying to implement it with just the photoView in the asset_page, but assumed there was a reason for video_viewer being architected this way, so I tried to stick with it. I never thought to ask about that, my bad!

[uhthomas]

@shenlong-tanwen thank you! The nested photo view is causing strange subtle issues. I am not sure why this wasn't caught during the review but /shrug.

@goalie2002 No need to apologise, your contributions are hugely appreciated.

[uhthomas]

with #26545, the sized box should be removed

[shenlong-tanwen]

I've left it in for now to be removed in your PR

[goalie2002]

I ran a quick test on this and I noticed that it lets you zoom into the black bars around the video; essentially the zoomable area is the entire screen instead of just the video itself. This differs from the way it works on photos and the previous implementation of video zooming on main

[shenlong-tanwen]

I ran a quick test on this and I noticed that it lets you zoom into the black bars around the video; essentially the zoomable area is the entire screen instead of just the video itself. This differs from the way it works on photos and the previous implementation of video zooming on main

I don't see this. Do you have a sample asset where I can reproduce this or a recording of the issue?

[goalie2002]

I don't see this. Do you have a sample asset where I can reproduce this or a recording of the issue?

screen-20260302-100551.2.-.Trim.mp4

IIRC it's caused by the Center widget expanding to the parent's size, and my fix previously was to calculate the required size myself

[uhthomas]

@goalie2002 explicit sizing in #26545 should resolve that.

[goalie2002]

@goalie2002 explicit sizing in #26545 should resolve that.

Awesome, I'll give that one a test!

[uhthomas]

Sounds good! It needs rebasing, which I'll do in a couple of hours.