Skip to content

fix(server): remove auth from Obtainium android-links endpoint and change android to apk, now apk-links #18787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
NicholasFlamy wants to merge 1 commit into from
Closed

fix(server): remove auth from Obtainium android-links endpoint and change android to apk, now apk-links #18787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion mobile/openapi/README.md
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

10 changes: 5 additions & 5 deletions mobile/openapi/lib/api/server_api.dart
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

15 changes: 2 additions & 13 deletions open-api/immich-openapi-specs.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5275,9 +5275,9 @@
]
}
},
"/server/android-links": {
"/server/apk-links": {
"get": {
"operationId": "getAndroidLinks",
"operationId": "getApkLinks",
"parameters": [],
"responses": {
"200": {
Expand All @@ -5291,17 +5291,6 @@
"description": ""
}
},
"security": [
{
"bearer": []
},
{
"cookie": []
},
{
"api_key": []
}
],
"tags": [
"Server"
]
Expand Down
4 changes: 2 additions & 2 deletions open-api/typescript-sdk/src/fetch-client.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2874,11 +2874,11 @@ export function getAboutInfo(opts?: Oazapfts.RequestOpts) {
...opts
}));
}
export function getAndroidLinks(opts?: Oazapfts.RequestOpts) {
export function getApkLinks(opts?: Oazapfts.RequestOpts) {
return oazapfts.ok(oazapfts.fetchJson<{
status: 200;
data: ServerApkLinksDto;
}>("/server/android-links", {
}>("/server/apk-links", {
...opts
}));
}
Expand Down
7 changes: 3 additions & 4 deletions server/src/controllers/server.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,10 +35,9 @@ export class ServerController {
return this.service.getAboutInfo();
}

@Get('android-links')
@Authenticated()
getAndroidLinks(): ServerApkLinksDto {
return this.service.getAndroidLinks();
@Get('apk-links')
getApkLinks(): ServerApkLinksDto {
return this.service.getApkLinks();
}

@Get('storage')
Expand Down
2 changes: 1 addition & 1 deletion server/src/services/server.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export class ServerService extends BaseService {
};
}

getAndroidLinks(): ServerApkLinksDto {
getApkLinks(): ServerApkLinksDto {
const baseUrl = `https://github.com/immich-app/immich/releases/download/v${serverVersion.toString()}`;
return {
arm64v8a: `${baseUrl}/app-arm64-v8a-release.apk`,
Expand Down
Loading