fix(server): remove auth from Obtainium android-links endpoint and change android to apk, now apk-links#18787
Closed
NicholasFlamy wants to merge 1 commit intoimmich-app:mainfrom
Closed
Conversation
android-links endpoint and change android to apkandroid-links endpoint and change android to apk, now apk-links
Member
|
I don't think |
Member
|
Idk. This is a bigger discussion. Let's decide on discord, make a decision, and then make the appropriate changes. Some things can't require auth, like whether oauth is enabled or not, since we need to know whether to show the button on the login page or not. |
Collaborator
Author
Alright, please let me know when y'all decide. If y'all decide to add auth to the version endpoint, I'll update this PR to keep auth. |
6 tasks
Collaborator
Author
|
Closing and replacing with #18790 because I wanted the branch name to be more accurate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I removed the
@Authenticated()tag because the version endpoint doesn't have auth and this endpoint is literally just the GitHub releases apk links but with the server version. Also, I think we decided apk instead of android, but I didn't update that everywhere (oops).Renames and removes auth from #18700
How Has This Been Tested?
make devAPI Changes
The
/api/server/android-linksendpoint is now/api/server/apk-linksand it no longer requires auth.Checklist:
src/services/uses repositories implementations for database calls, filesystem operations, etc.src/repositories/is pretty basic/simple and does not have any immich specific logic (that belongs insrc/services/)