Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fixed typo w/ srcset min/max widths #97

Merged
merged 1 commit into from
Dec 15, 2020
Merged

docs: fixed typo w/ srcset min/max widths #97

merged 1 commit into from
Dec 15, 2020

Conversation

scttdavs
Copy link
Contributor

Description

This PR fixes a couple issues in the docs with min_width and max_width not being documented correctly. I had to dig through the source code to figure out why things were not working as expected. Hopefully this saves some others some time.

Checklist: Fixing typos/Doc change

  • Each commit follows the Conventional Commit format: e.g. chore(readme): fixed typo. See the end of this file for more information.

@scttdavs scttdavs requested a review from a team as a code owner December 15, 2020 00:36
ericdeansanchez
ericdeansanchez approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@ericdeansanchez ericdeansanchez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey 👋 thanks for opening this PR and catching this. We really appreciate it!

sherwinski
sherwinski approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@sherwinski sherwinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, thanks @scttdavs 👍

@ericdeansanchez ericdeansanchez merged commit a86e56f into imgix:main Dec 15, 2020
@ericdeansanchez ericdeansanchez mentioned this pull request Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericdeansanchez ericdeansanchez ericdeansanchez approved these changes

@sherwinski sherwinski sherwinski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@scttdavs @sherwinski @ericdeansanchez