Skip to content
This repository has been archived by the owner on Dec 22, 2024. It is now read-only.

fix aarch64 AMP download links in dockerfile #8

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

rekonnected
Copy link
Contributor

Fixed the links in Dockerfile.aarch64 so it now downloads and runs AMP properly on an ARM64 host. Tested on an M1 Mac and Oracle ARM VM.

@ImageGeniusCI
Copy link
Contributor

I am a bot, here is the pushed image/manifest for this PR:

:2.4.4.0-pkg-1d3051e2-pr-8

@hydazz
Copy link
Member

hydazz commented Jun 27, 2023

good work, thanks 😄

@hydazz hydazz merged commit c136cb1 into imagegenius:main Jun 27, 2023
@rekonnected
Copy link
Contributor Author

Happy to help, tried to do this once already for MitchTalmadge/AMP-dockerized#140 (which involved a lot more work) but it was never merged, so I was happy to see all this needed was a link change.

Make sure to update the readme to reflect arm64 support is now good, I forgot to in my repo lol

@hydazz
Copy link
Member

hydazz commented Jun 27, 2023

you had no issues in testing? this image uses alpine + glibc and would assume that it would not "just" work (it never does)

@rekonnected
Copy link
Contributor Author

rekonnected commented Jun 28, 2023

you had no issues in testing? this image uses alpine + glibc and would assume that it would not "just" work (it never does)

Ran through it a bit more in depth to double check it actually fully loads a proper java MC server, yep, it actually 'just' worked! Only catch I see so far may be inconsequential, the spec in the top bar isn't reading properly, idk if it actually uses that core count for anything other than an info display so it may not matter

(this is on the oracle 24G ARM server)
CleanShot 2023-06-28 at 01 26 08@2x

CleanShot 2023-06-28 at 01 29 05@2x

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants