Adapt Dockerfile and build.yml to enable arm64 builds #140
Conversation
…onboot Fix Start On Boot
Adjustments must be made for portainer to work.
…tainer-patch add portainer compose file
Splitting the dependencies into their own sets made it easier to selectively exclude the srcds dependencies when arch is arm64, since they don't work
This should hopefully enable Github Workflows to automatically build it in multiarch
|
@MitchTalmadge have you had a chance to take a look at this? |
|
@MitchTalmadge It's been 6 months since this was submitted with no acknowledgement or anything, would you be able to look at this please? |
|
This looks great!! ❤️ I really appreciate the time and effort you put into this, and I sincerely apologize for never getting back to you on it. See #162. I'm merging it into staging and we'll see how it goes! |
|
The build succeeded! The docker push did not, though. :P I need to tweak the script to handle the different architectures more appropriately. |
|
Totally understood, no worries. Was just worried the project got completely abandoned which would have been unfortunate given CC's insistence that the whole thing "can't" run in docker alone (which you're sadly very familiar with). Really happy the build itself worked though, this was my first foray into docker image creation/management and I just wanted it to run on an Oracle virtual machine 😅 |
The dockerfile is what makes the arm64 image work as long as you build it with --platform linux/amd64,linux/arm64 (if building manually).
The singular change in build.yml tells GH to make both automatically.
I might not have done this in the absolute best/most efficient way, but I think it's pretty clean and it works from my testing.