Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid allocation in ScopedTimer call #54

Merged
merged 1 commit into from
Feb 19, 2024
Merged

Avoid allocation in ScopedTimer call #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions src/DotRecast.Detour.Crowd/DtCrowdTelemetry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,24 @@ namespace DotRecast.Detour.Crowd
{
public class DtCrowdTelemetry
{
public readonly struct DisposableHandle : IDisposable
{
private readonly DtCrowdTimerLabel _label;
private readonly DtCrowdTelemetry _telemetry;

public DisposableHandle(DtCrowdTelemetry telemetry, DtCrowdTimerLabel label)
{
_telemetry = telemetry;
_label = label;
}

public void Dispose()
{
_telemetry.Stop(_label);
}
}


public const int TIMING_SAMPLES = 10;
private float _maxTimeToEnqueueRequest;
private float _maxTimeToFindPath;
Expand Down Expand Up @@ -69,10 +87,10 @@ public void RecordMaxTimeToFindPath(float time)
_maxTimeToFindPath = Math.Max(_maxTimeToFindPath, time);
}

public IDisposable ScopedTimer(DtCrowdTimerLabel label)
public DisposableHandle ScopedTimer(DtCrowdTimerLabel label)
{
Start(label);
return new RcAnonymousDisposable(() => Stop(label));
return new DisposableHandle(this, label);
}

private void Start(DtCrowdTimerLabel name)
Expand Down
Loading