Avoid disconnect on short read#235
Conversation
This implements the TODO to handle the short read. recv_into should be a bit more efficient as well.
bdraco
force-pushed
the
handle_disconnect_short_read
branch
from
ac451b3 to
ab3a110
Compare
Codecov Report
@@ Coverage Diff @@
## dev #235 +/- ##
==========================================
- Coverage 62.84% 62.70% -0.15%
==========================================
Files 16 16
Lines 1720 1724 +4
Branches 178 179 +1
==========================================
Hits 1081 1081
- Misses 594 598 +4
Partials 45 45
|
|
Not urgent as its rare. Likely could go with #231 |
|
May fix #230 |
|
Testing... |
|
Switched over 4 Home Assistant installs to the new code. so far so good |
|
Stable and very responsive with 347 devices linked between 4 hass installs |
|
All good overnight as well |
|
@ikalchev Any chance you have a spare moment to get another version bump? |
|
Yes I will do it tonight |
|
2.8.1 released. Let me know if something's wrong. I now see one test started failing, but I think it's the test itself that has issues. Will look more into it in the coming days. |
|
@ikalchev Thank you. Looks like its the camera test failing. Since Home Assistant doesn't have HAP camera support yet if there is something wrong it likely won't get noticed. |
3 participants
Handle short read in crypto stream
This implements the TODO to handle the short read.
recv_into should be a bit more efficient as well.