Skip to content

Bump HAP-python to 2.8.1#33756

Merged
springstan merged 1 commit intohome-assistant:devfrom
bdraco:hap_update_fix_short_read
Apr 6, 2020
Merged

Bump HAP-python to 2.8.1#33756
springstan merged 1 commit intohome-assistant:devfrom
bdraco:hap_update_fix_short_read

Conversation

@bdraco
Copy link
Copy Markdown
Member

@bdraco bdraco commented Apr 6, 2020

Proposed change

  • Bump to 2.8.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant probot-home-assistant Bot added integration: homekit small-pr PRs with less than 30 lines. dependency Pull requests marked as a dependency upgrade labels Apr 6, 2020
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 6, 2020

Fixes ikalchev/HAP-python#235

@bdraco bdraco added this to the 0.108.0 milestone Apr 6, 2020
@bdraco bdraco force-pushed the hap_update_fix_short_read branch from 27e4491 to 50911ea Compare April 6, 2020 20:35
@bdraco
Copy link
Copy Markdown
Member Author

bdraco commented Apr 6, 2020

rebase to rerun ci for unrelated failure

@springstan springstan changed the title Update HAP-python to fix disconnect on short read Bump HAP-python to 2.8.1 Apr 6, 2020
@springstan
Copy link
Copy Markdown
Member

Failing tests will be fixed by #33760

@springstan springstan merged commit cf563df into home-assistant:dev Apr 6, 2020
balloob pushed a commit that referenced this pull request Apr 6, 2020
@lock lock Bot locked and limited conversation to collaborators Apr 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cherry-picked cla-signed dependency Pull requests marked as a dependency upgrade integration: homekit small-pr PRs with less than 30 lines.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants