Skip to content

Optimize ephemeral E2E stack pinning - #856

Merged
ytallo merged 1 commit into
mainfrom
feat/batch-shadow-stack-pins
Aug 20, 2026
Merged

Optimize ephemeral E2E stack pinning#856
ytallo merged 1 commit into
mainfrom
feat/batch-shadow-stack-pins

Conversation

@ytallo

@ytallo ytallo commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary

  • batch exact v2 runtime and target pins before the runner
  • reapply the resolved union once after the runner
  • preserve the legacy v1 path unchanged

Validation

  • bash -n harness/tests/e2e/run-shadow-control-ci.sh
  • python3 -m pytest .github/scripts/tests/test_harness_e2e_shadow_contract.py -q
  • git diff --check

Summary by CodeRabbit

  • Bug Fixes
    • Improved reliability when installing pinned worker versions during setup and post-runner operations.
    • Ensured runtime and target versions are applied consistently for Schema 2 workflows.
    • Preserved existing installation behavior for legacy schemas.

@vercel

vercel Bot commented Aug 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
workers Ready Ready Preview Aug 20, 2026 2:57pm
workers-tech-spec Ready Ready Preview Aug 20, 2026 2:57pm

Request Review

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: b5789c64-3b92-441c-84d2-ee62f3a91139

📥 Commits

Reviewing files that changed from the base of the PR and between f0ad63c and 677d5a6.

📒 Files selected for processing (1)
  • harness/tests/e2e/run-shadow-control-ci.sh

📝 Walkthrough

Walkthrough

The CI script adds retry-enabled batch installation for exact worker versions. Schema 2 installs and repins the combined runtime and target stacks. Legacy schemas keep separate target installation and repinning.

Changes

Shadow control stack handling

Layer / File(s) Summary
Exact stack installation and schema routing
harness/tests/e2e/run-shadow-control-ci.sh
Adds install_exact_stack for sorted worker pins with retries and force enabled. Schema 2 merges runtime and target versions for installation and repinning. Legacy schemas retain separate target-stack handling.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • iii-hq/workers#846: Introduces the schema 2 stack-installation and repinning logic extended by this change.

Poem

A rabbit checks each worker pin,
Then retries till the stacks fit in.
Schema two joins paths as one,
Legacy keeps its work well done.
Exact versions hop in line.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/batch-shadow-stack-pins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

skill-check — worker

0 verified, 62 skipped (no docs/).

Layer Result
structure
vale
ai
render

Four for four. Nicely done.

@ytallo ytallo added the no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only) label Aug 20, 2026
@ytallo
ytallo marked this pull request as ready for review August 20, 2026 15:05
@ytallo
ytallo merged commit eaaafc5 into main Aug 20, 2026
27 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-ticket PR deliberately has no Linear ticket (bump/typo/CI-only)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant