Support exact manual E2E stack contracts - #846
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
📝 WalkthroughWalkthroughThe change adds schema v2 execution contracts with canonical digests, resolved stack validation, lock verification, and exact runner pins. The workflow and E2E harness now use schema-aware versions, OIDC audiences, configuration paths, and admission payloads. ChangesExecution contract v2
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant GitHubWorkflow
participant ExecutionContractTool
participant AdmissionService
participant ShadowControlCI
GitHubWorkflow->>ExecutionContractTool: compute contract digest and OIDC audience
GitHubWorkflow->>AdmissionService: submit digest and request token with derived audience
ShadowControlCI->>ExecutionContractTool: verify installed versions against contract
ExecutionContractTool-->>ShadowControlCI: return lock manifest
Possibly related PRs
Poem
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 62 skipped (no docs/).
Four for four. Nicely done. |
Summary
Validation
python3 -m pytest .github/scripts/tests/ -q(207 passed, 3 subtests passed)python3 -m py_compile .github/scripts/harness_e2e_shadow_contract.pybash -n harness/tests/e2e/run-shadow-control-ci.shgit diff --checkThis fixes the production mismatch where Release Control emits schema v2 manual-stack contracts while the published workflow accepted only v1.
Summary by CodeRabbit
New Features
Bug Fixes