(MOT-4412) fix(release): invalidate embedded frontend cache - #788
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe Rust binary workflow now publishes a deterministic digest for staged frontend files, includes it in frontend-enabled Cargo cache keys, and verifies restored frontend artifacts on each build shard. Tests cover the output, hashing, cache, and verification wiring. ChangesFrontend digest validation
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: Poem
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 58 skipped (no docs/).
Four for four. Nicely done. |
Summary
Root cause
llm-router1.4.6 was tagged from source containing the fresh-install provider fix, and the frontend build job produced the correctedpage.js. The final binary still embedded the previous bundle because the cross-target Cargo cache key represented Rust manifests and locks but not the generated frontend bytes restored afterward.Impact
A frontend change now selects a different Cargo cache generation for every release target. Identical frontend output keeps its cache reuse, while changed output cannot restore a worker artifact containing stale
include_str!orrust-embeddata. The digest is verified again after artifact download before compilation.Testing
.github/scriptstests and 3 subtests passedactionlint1.7.12 passedllm-router/ui/distgit diff --checkFollow-up to #785.
Refs MOT-4412
Summary by CodeRabbit
Bug Fixes
Tests