(MOT-4412) fix(llm-router): show providers on fresh installs - #785
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe configuration UI now discovers provider cards from both the registered schema and saved configuration. New tests cover merging, empty values, and fresh installations. Vitest is configured for Node.js and exposed through the UI test script. ChangesProvider Card Discovery
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to This localized change restores provider cards for fresh installations while preserving configured entries, with focused tests and builds reported; no actionable merge-blocking risk remains. Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
skill-check — worker0 verified, 58 skipped (no docs/).
Four for four. Nicely done. |
Summary
Root cause
Fresh installations return
nullfor thellm-routerconfiguration value. The custom form built its cards only fromvalue.providers, so it rendered an empty provider section even though the registered schema already contained Anthropic and OpenAI.Impact
Users can configure provider credentials immediately after installing Harness and Console, without first creating an llm-router configuration entry through another path.
Testing
pnpm --filter @iii-workers/llm-router-ui testpnpm --filter @iii-workers/llm-router-ui buildcargo build --manifest-path llm-router/Cargo.toml127.0.0.1:3113with a null llm-router configurationRefs MOT-4412
Summary by CodeRabbit
Bug Fixes
Tests